[Mesa-dev] [PATCH 00/11] Another series of patches fixing dEQP failing tests

[Eduardo Lima Mitev]

Hello,

Here goes another batch of fixes for dEQP failing tests. It fixes a total of 47 test cases.
The test failures were gathered on i965 (gen8) against 10.4.2, but there are driver and version agnostic fixes.

A GIT tree with these patches based on git-d74a8 is available at: https://github.com/Igalia/mesa/tree/deqp-fixes-batch3-rebased


There is one known piglit regression (test 'glslparsertest/glsl2/precision-05.vert') caused by patch 07  (glsl: error out on empty declarations). We probably want to drop this patch even if it fixes dEQP tests that expect to do what the patch suggests. The rationale here is that this  conflicts with commit 547212d963c7 (introduced in 2011), that made this a warning only. The commit log says:

"Some apps that generate their shader sources may rely on this. This was noted when porting one of them to Linux from Windows."

The regressed piglit tests relies on such behavior and also suggests that this sort of thing is allowed by other drivers. Both the commit and the piglit test acknowledge that the spec isn't explicit about this subject, however it looks that the OpenGL ES3 spec is, since it includes the following grammar rule for declarations (OpenGL ES3 spec, Shasing Language Grammar, page 106):

declaration:
   type_qualifier SEMICOLON

which seems to contemplate empty declarations as valid.

Based on this, we think these dEQP tests might not be correct, but even if they are, we might not want to fix them.


cheers,
Eduardo


Eduardo Lima Mitev (3):
  mesa: Returns a GL_INVALID_VALUE error on several glGet* APIs when max
    length is negative
  mesa: Validate internal format and format type first to provide
    accurate error code
  mesa: Allow querying for GL_PRIMITIVE_RESTART_FIXED_INDEX under GLES 3
Iago Toral Quiroga (7):
  glsl: Add link time checks for GLSL precision qualifiers
  i965: Fix negate with unsigned integers
  glsl: interface blocks must be declared at global scope
  glsl: can't have 'const' qualifier used with struct or interface block
    members
  glsl: error out on empty declarations
  glsl: GLSL ES identifiers cannot exceed 1024 characters
  glsl: Improve precision of mod(x,y)
Samuel Iglesias Gonsalvez (1):
  mesa: fix error value in GetFramebufferAttachmentParameteriv for
    OpenGL ES 3.0
 src/glsl/README                                    |   2 +-
 src/glsl/ast_to_hir.cpp                            |  31 +++++-
 src/glsl/glsl_parser.yy                            |   7 ++
 src/glsl/glsl_types.cpp                            |   4 +
 src/glsl/glsl_types.h                              |  13 +++
 src/glsl/ir.h                                      |  15 +++
 src/glsl/ir_optimization.h                         |   2 +-
 src/glsl/linker.cpp                                |  48 +++++++--
 src/glsl/lower_instructions.cpp                    |  49 +++++----
 .../drivers/dri/i965/brw_fs_copy_propagation.cpp   |   9 +-
 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp       |   2 +-
 src/mesa/drivers/dri/i965/brw_shader.cpp           |   2 +-
 .../drivers/dri/i965/brw_vec4_copy_propagation.cpp |   9 +-
 src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp     |   2 +-
 src/mesa/main/fbobject.c                           |   2 +-
 src/mesa/main/get_hash_params.py                   |   5 +
 src/mesa/main/glformats.c                          | 114 +++++++++++++++++++++
 src/mesa/main/shader_query.cpp                     |   5 +
 src/mesa/main/shaderapi.c                          |  10 ++
 src/mesa/main/uniform_query.cpp                    |   5 +
 src/mesa/program/ir_to_mesa.cpp                    |   4 +-
 src/mesa/state_tracker/st_glsl_to_tgsi.cpp         |   2 +-
 22 files changed, 289 insertions(+), 53 deletions(-)
-- 
2.1.3