[Mesa-dev] [PATCH 07/11] glsl: error out on empty declarations

Eduardo Lima Mitev elima at igalia.com
Mon Jan 19 03:32:13 PST 2015


From: Iago Toral Quiroga <itoral at igalia.com>

So far we have only been emitting a warning.

Fixes the following 2 dEQP tests:
dEQP-GLES3.functional.shaders.arrays.invalid.empty_declaration_without_var_name_vertex
dEQP-GLES3.functional.shaders.arrays.invalid.empty_declaration_without_var_name_fragment
---
 src/glsl/ast_to_hir.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index c52e4af..5ed8b0e 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -3406,7 +3406,7 @@ ast_declarator_list::hir(exec_list *instructions,
                "lowp"
             };
 
-            _mesa_glsl_warning(&loc, state,
+            _mesa_glsl_error(&loc, state,
                                "empty declaration with precision qualifier, "
                                "to set the default precision, use "
                                "`precision %s %s;'",
@@ -3414,7 +3414,7 @@ ast_declarator_list::hir(exec_list *instructions,
                                type_name);
          }
       } else if (this->type->specifier->structure == NULL) {
-         _mesa_glsl_warning(&loc, state, "empty declaration");
+         _mesa_glsl_error(&loc, state, "empty declaration");
       }
    }
 
-- 
2.1.3



More information about the mesa-dev mailing list