[Mesa-dev] [PATCH 07/16] i965: Add is_3src() to backend_instruction.

Kenneth Graunke kenneth at whitecape.org
Tue Jan 20 00:16:04 PST 2015


On Monday, January 19, 2015 03:31:06 PM Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_shader.cpp                | 10 ++++++++++
>  src/mesa/drivers/dri/i965/brw_shader.h                  |  1 +
>  src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp |  6 +-----
>  3 files changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp
> index cbdf976..c6fead7 100644
> --- a/src/mesa/drivers/dri/i965/brw_shader.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
> @@ -678,6 +678,16 @@ backend_reg::is_accumulator() const
>  }
>  
>  bool
> +backend_instruction::is_3src() const
> +{
> +   return opcode == BRW_OPCODE_LRP ||
> +          opcode == BRW_OPCODE_MAD ||
> +          opcode == BRW_OPCODE_BFE ||
> +          opcode == BRW_OPCODE_BFI2 ||
> +          opcode == BRW_OPCODE_CSEL;

Pah, manual listings of things :)  Let's do even better:

   return opcode < 128 && opcode_descs[op].nsrc == 3;

That would get
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150120/97e7e475/attachment-0001.sig>


More information about the mesa-dev mailing list