[Mesa-dev] [PATCH 2/3] i965: Fix min_vs_entries for CHV

Kenneth Graunke kenneth at whitecape.org
Wed Jan 21 12:49:41 PST 2015


On Wednesday, January 21, 2015 08:17:35 PM ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> According to BSpec the correct number for min_vs_entries is 34 for CHV.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_device_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c b/src/mesa/drivers/dri/i965/brw_device_info.c
> index 2c3af66..bdef42b 100644
> --- a/src/mesa/drivers/dri/i965/brw_device_info.c
> +++ b/src/mesa/drivers/dri/i965/brw_device_info.c
> @@ -244,7 +244,7 @@ static const struct brw_device_info brw_device_info_chv = {
>     .max_wm_threads = 128,
>     .urb = {
>        .size = 128,
> -      .min_vs_entries = 64,
> +      .min_vs_entries = 34,
>        .max_vs_entries = 640,
>        .max_gs_entries = 256,
>     }
> 

Yes, it is.  Thanks!  Given that we always try to allocate the VS as much
space as possible, I doubt this will have much practical impact - and we're
overallocating now - so I don't think it's a stable candidate.

Definitely worth fixing though.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150121/8d38be08/attachment.sig>


More information about the mesa-dev mailing list