[Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

Matt Turner mattst88 at gmail.com
Wed Jan 21 15:53:56 PST 2015


On Wed, Jan 21, 2015 at 3:19 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Okay, I see what you're doing now.  It's definitely not what my
> brw_negate_cmod function did.  This is why you absolutely need
> doxygen comments, ideally with an example.  The functions for
> (a cmp1 b) -> !(a cmp1 b) and (a cmp1 b) -> (!a cmp2 !b) look
> way too similar at a glance...

Sure, that would have prevented confusion. I'll add

/* Returns the corresponding conditional mod for negating both operands to a
 * CMP.
 */


More information about the mesa-dev mailing list