[Mesa-dev] [PATCH v1] Remove UINT_AS_FLT, INT_AS_FLT, FLOAT_AS_FLT macros.No functional changes, only bug fixed.

[Kenneth Graunke]

On Thursday, January 22, 2015 12:12:18 AM marius.predut at intel.com wrote:
> From: Marius Predut <marius.predut at intel.com>
> 
> On 32-bit, for floating point operations is used x86 FPU registers instead SSE,
> reason for  when reinterprets an integer as a float result is unexpected
> (modify floats when they are written to memory).
>
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82668
> 
> Signed-off-by: Marius Predut <marius.predut at intel.com>
> ---
>  src/mesa/main/context.c       |    3 ++-
>  src/mesa/main/macros.h        |   32 ++++++++++++++++----------------
>  src/mesa/vbo/vbo_attrib_tmp.h |   20 ++++++++++++++++----
>  src/mesa/vbo/vbo_exec.h       |    3 ++-
>  src/mesa/vbo/vbo_exec_api.c   |   25 ++++++++++++-------------
>  src/mesa/vbo/vbo_exec_eval.c  |   22 +++++++++++++++++-----
>  src/mesa/vbo/vbo_save_api.c   |   10 +++++-----
>  7 files changed, 70 insertions(+), 45 deletions(-)

Your commit title says "No functional changes, only bug fixed."  This is
contradictory - a bug fix is a change in behavior, or a "functional change."

"No functional changes" is a phrase used for patches which alter whitespace,
comments, change style, or move code around while not actually changing the
result of the code.

Removing the macros is also not really the point of the patch - it's fixing
an x86 FPU bug.  I would make the commit title something to that effect.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150121/5fa16ebc/attachment.sig>