[Mesa-dev] [PATCH] configure: Link against all LLVM targets when building clover

[Jan Vesely]

On Thu, 2015-01-22 at 21:11 +0100, Niels Ole Salscheider wrote:
> On Thursday 22 January 2015, 13:46:14, Jan Vesely wrote:
> > On Thu, 2015-01-22 at 16:45 +0000, Emil Velikov wrote:
> > > On 15/01/15 21:38, Tom Stellard wrote:
> > > > On Thu, Jan 15, 2015 at 07:25:56PM +0100, Niels Ole Salscheider wrote:
> > > >> Since 8e7df519bd8556591794b2de08a833a67e34d526, we initialise all
> > > >> targets in clover. This fixes bug 85189.
> > > >> 
> > > >> Signed-off-by: Niels Ole Salscheider <niels_ole at salscheider-online.de>
> > > > 
> > > > Reviewed-by: Tom Stellard <thomas.stellard at amd.com>
> > > 
> > > Hi Niels,
> > > 
> > > Can you confirm if this is needed for the 10.4 branch ? The commit
> > > mentioned got in the 10.4 devel cycle.
> > > 
> > > Also the bug mentioned
> > > (https://bugs.freedesktop.org/show_bug.cgi?id=85189) seems to have
> > > alternative fix which is already in master. I take that this fix is
> > > required when building with static llvm ?

It depends on how the LLVM build process produces libraries. AFAIK, LLVM
autotools build produces one dynamic (libLLVM-X.Y.so) with all targets,
and per target static libraries (e.g libLLVMR600Codegen.a).
However, it's possible to setup cmake (maybe autotools as well) to
produce separate dynamic libraries per target (e.g
libLLVMR600CodeGen.so), so it's possible to hit the issue with dynamic
libraries as well (I do see it on my setup).

I'd say it's correct to use this patch in every setup, since the
autotools dynamic build only works 'by accident'.

jan

> > 
> > the patch looks like it fixes
> > https://bugs.freedesktop.org/show_bug.cgi?id=85380
> > instead of 85189
> 
> Yes, Jan is right. This patch fixes bug 85380 instead of 85189 - this was 
> probably a copy&paste error.
> 
> This patch is relevant for the 10.4 branch, too, since commit 
> 8e7df519bd8556591794b2de08a833a67e34d526 is in it.
> 
> Ole
> 
> > jan
> > 
> > > Thanks
> > > Emil
> > > 
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150122/1c48dc92/attachment-0001.sig>