[Mesa-dev] [PATCH 1/2] mesa: fix a trivial spelling mistake

Kenneth Graunke kenneth at whitecape.org
Mon Jan 26 10:12:32 PST 2015


On Monday, January 26, 2015 07:52:46 AM Brian Paul wrote:
> On 01/19/2015 02:26 AM, Martin Peres wrote:
> >
> > On 19/01/15 11:25, Kenneth Graunke wrote:
> >> On Monday, January 19, 2015 10:52:05 AM Martin Peres wrote:
> >>> Signed-off-by: Martin Peres <martin.peres at linux.intel.com>
> >>> ---
> >>>   src/mesa/main/feedback.c | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/src/mesa/main/feedback.c b/src/mesa/main/feedback.c
> >>> index 9ea0b92..6bc4294 100644
> >>> --- a/src/mesa/main/feedback.c
> >>> +++ b/src/mesa/main/feedback.c
> >>> @@ -89,7 +89,7 @@ _mesa_FeedbackBuffer( GLsizei size, GLenum type,
> >>> GLfloat *buffer )
> >>>      ctx->Feedback.Type = type;
> >>>      ctx->Feedback.BufferSize = size;
> >>>      ctx->Feedback.Buffer = buffer;
> >>> -   ctx->Feedback.Count = 0;                  /* Becaues of this. */
> >>> +   ctx->Feedback.Count = 0;                  /* Because of this. */
> >>>   }
> >> Pushed, thanks!
> >>
> >> Good ol' GL 1.x code that hasn't been worked on in 3-4 years... :)
> >
> > Yeah, I spotted that while looking for the transform feedback code :)
> 
> What does that comment even mean?  I'd say just remove it.
> 
> -Brian

I was going to say the same thing, but with a bit more context, it makes
sense:

   FLUSH_VERTICES(ctx, _NEW_RENDERMODE); /* Always flush */
   ctx->Feedback.Type = type;
   ctx->Feedback.BufferSize = size;
   ctx->Feedback.Buffer = buffer;
   ctx->Feedback.Count = 0;                   /* Because of this. */

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150126/6cd06f44/attachment.sig>


More information about the mesa-dev mailing list