[Mesa-dev] [PATCH 3/4] drirc: add workarounds for Unigine Tropics

[Glenn Kennard]

On Fri, 30 Jan 2015 15:19:49 +0100, Martin Peres  
<martin.peres at linux.intel.com> wrote:

> Signed-off-by: Martin Peres <martin.peres at linux.intel.com>
> ---
>  src/mesa/drivers/dri/common/drirc | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/common/drirc  
> b/src/mesa/drivers/dri/common/drirc
> index cecd6a9..073814e 100644
> --- a/src/mesa/drivers/dri/common/drirc
> +++ b/src/mesa/drivers/dri/common/drirc
> @@ -10,6 +10,11 @@ Application bugs worked around in this file:
>    Enabling all extensions for Unigine fixes most issues, but the GLSL  
> version
>    is still 1.10.
> +* Unigine Tropics 1.3 makes use of the "sample" keyword which is  
> reserved
> +  with ARB_GL_gpu_shader5 which got enabled by  
> force_glsl_extensions_warn.

There seems to be something weird going on here - as far as I can tell  
Tropics is using a GL legacy context, and for those
GL_ARB_GL_gpu_shader5 isn't supposed to be enabled, the extension spec  
mentions GL 3.2 compatibility/core profile being required.

If i test this on r600 the extension cannot be enabled in a legacy  
context, only in a core one. Maybe there is a check missing somewhere in  
the intel driver?

> +  It also makes use of bitwise manipulation (when adding anistropic  
> filtering)
> +  which is illegal in GLSL 1.10. Adding "#version 130" fixes this.
> +
>  * Unigine Heaven 3.0 with ARB_texture_multisample uses a "ivec4 * vec4"
>    expression, which is illegal in GLSL 1.10.
>    Adding "#version 130" fixes this.
> @@ -41,6 +46,8 @@ TODO: document the other workarounds.
>         <application name="Unigine Tropics" executable="Tropics">
>              <option name="force_glsl_extensions_warn" value="true" />
> +            <option name="mesa_extension_override"  
> value="-GL_ARB_gpu_shader5" />
> +            <option name="force_glsl_version" value="130" />
>              <option name="disable_blend_func_extended" value="true" />
>  	</application>
>

force_glsl_version addition LGTM.