[Mesa-dev] [PATCH] main: Add STENCIL_INDEX formats to base_tex_format

[Jason Ekstrand]

On Fri, Jan 30, 2015 at 3:03 PM, Matt Turner <mattst88 at gmail.com> wrote:

> On Fri, Jan 30, 2015 at 2:27 PM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > This fixes a bug on BDW when our meta-based stencil blit path
> assert-fails
> > due to an invalid internal format even though we do support the
> > ARB_stencil_texturing extension.
> > ---
> >  src/mesa/main/teximage.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> > index 03264dd..0e37613 100644
> > --- a/src/mesa/main/teximage.c
> > +++ b/src/mesa/main/teximage.c
> > @@ -221,6 +221,16 @@ _mesa_base_tex_format( struct gl_context *ctx,
> GLint internalFormat )
> >        }
> >     }
> >
> > +   if (ctx->Extensions.ARB_stencil_texturing) {
> > +      switch (internalFormat) {
> > +         case GL_STENCIL_INDEX:
>
> Don't indent case.
>
> > +         case GL_STENCIL_INDEX8:
> > +            return GL_STENCIL_INDEX;
> > +         default:
> > +            ; /* fallthrough */
>
> Just make this a break statement.
>

Both of the above are consistent with the rest of the function.  How much
do we care about style vs. consistency?


>
> I don't really know this code, but it seems fine otherwise.
>
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150130/b977eace/attachment.html>