[Mesa-dev] [PATCH 07/43] st/nine: Fix use of D3DSP_NOSWIZZLE

Henri Verbeet hverbeet at gmail.com
Sat Jan 31 02:12:08 PST 2015


On 30 January 2015 at 21:34, Axel Davy <axel.davy at ens.fr> wrote:
> @@ -2778,7 +2778,7 @@ sm1_parse_get_param(struct shader_translator *tx, DWORD *reg, DWORD *rel)
>              *rel = (1 << 31) |
>                  ((D3DSPR_ADDR << D3DSP_REGTYPE_SHIFT2) & D3DSP_REGTYPE_MASK2) |
>                  ((D3DSPR_ADDR << D3DSP_REGTYPE_SHIFT)  & D3DSP_REGTYPE_MASK) |
> -                (D3DSP_NOSWIZZLE << D3DSP_SWIZZLE_SHIFT);
> +                D3DSP_NOSWIZZLE;
>          else
>              *rel = TOKEN_NEXT(tx);
>      }

I can't help but notice a certain amount of similarity between the
naming and structuring of the SM1 parser here and the one in Wine. I
assume that's because it's the one and only logical way to write such
a parser. Just in case though, I'd like to explicitly state that we'd
welcome anyone reusing Wine's code, provided the terms of the LGPL are
respected.


More information about the mesa-dev mailing list