[Mesa-dev] [PATCH 2/4] gallium/ttn: IN/OUT are only array if ArrayID != 0

Eric Anholt eric at anholt.net
Wed Jul 1 13:26:52 PDT 2015


Rob Clark <robdclark at gmail.com> writes:

> From: Rob Clark <robclark at freedesktop.org>
>
> Fixes issue with gallium HUD.  See this thread for details:
> http://lists.freedesktop.org/archives/mesa-dev/2015-June/087140.html

I had to apply and git show -b to make any sense of this.

This block is getting really ugly looking (I think a "num_decls" and
"array_size[_per_decl]" would have clarified things for me), and I'm
kind of bothered that we're not just splitting non-variable-indexed
array declarations at the NIR level (which would also solve the problem
it seems), but this seems correct, so:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150701/4aadb005/attachment.sig>


More information about the mesa-dev mailing list