[Mesa-dev] [PATCH 4/5] i965/fs: remove special case in setup_payload_interference()

[Jordan Justen]

On 2015-07-01 11:51:38, Connor Abbott wrote:
> From: Connor Abbott <cwabbott0 at gmail.com>
> 
> regs_read() will handle LINTERP for us since the previous commit. In
> addition, we were being too conservative, since it will only read 2
> registers on SIMD8.
> 
> instructions in affected programs:     9061 -> 8893 (-1.85%)
> helped:                                10
> HURT:                                  0
> GAINED:                                0
> LOST:                                  0

Nice. :)

Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

> All of the changes were due to spills being eliminated, mostly in KSP
> shaders.
> 
> Signed-off-by: Connor Abbott <connor.w.abbott at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 20 --------------------
>  1 file changed, 20 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> index 620fc23..1ee19e4 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
> @@ -389,26 +389,6 @@ fs_visitor::setup_payload_interference(struct ra_graph *g,
>  
>        /* Special case instructions which have extra implied registers used. */
>        switch (inst->opcode) {
> -      case FS_OPCODE_LINTERP:
> -         /* On gen6+ in SIMD16, there are 4 adjacent registers used by
> -          * PLN's sourcing of the deltas, while we list only the first one
> -          * in the arguments.  Pre-gen6, the deltas are computed in normal
> -          * VGRFs.
> -          */
> -         if (devinfo->gen >= 6) {
> -            int delta_x_arg = 0;
> -            if (inst->src[delta_x_arg].file == HW_REG &&
> -                inst->src[delta_x_arg].fixed_hw_reg.file ==
> -                BRW_GENERAL_REGISTER_FILE) {
> -               for (int i = 1; i < 4; ++i) {
> -                  int node = inst->src[delta_x_arg].fixed_hw_reg.nr + i;
> -                  assert(node < payload_node_count);
> -                  payload_last_use_ip[node] = use_ip;
> -               }
> -            }
> -         }
> -         break;
> -
>        case CS_OPCODE_CS_TERMINATE:
>           payload_last_use_ip[0] = use_ip;
>           break;
> -- 
> 2.4.3
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev