[Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

[Chris Forbes]

Seems fair.

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

On Thu, Jul 2, 2015 at 10:22 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> The optimization logic relies on being able to read out constbuf values
> from program parameters. However that only works if there's no relative
> addressing involved.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91173
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/mesa/program/prog_opt_constant_fold.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/program/prog_opt_constant_fold.c b/src/mesa/program/prog_opt_constant_fold.c
> index 3811c0d..e2518e6 100644
> --- a/src/mesa/program/prog_opt_constant_fold.c
> +++ b/src/mesa/program/prog_opt_constant_fold.c
> @@ -38,6 +38,8 @@ src_regs_are_constant(const struct prog_instruction *inst, unsigned num_srcs)
>     for (i = 0; i < num_srcs; i++) {
>        if (inst->SrcReg[i].File != PROGRAM_CONSTANT)
>          return false;
> +      if (inst->SrcReg[i].RelAddr)
> +         return false;
>     }
>
>     return true;
> --
> 2.3.6
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev