[Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

[Emil Velikov]

On 27 June 2015 at 12:21, Jon TURNEY <jon.turney at dronecode.org.uk> wrote:
> On 19/06/2015 12:51, Emil Velikov wrote:
>>
>> On 19 June 2015 at 00:05, Julien Isorce <julien.isorce at gmail.com> wrote:
>>>
>>> Sorry for removing the XXX line. Original message is here:
>>> https://bugs.freedesktop.org/attachment.cgi?id=115539
>>>
>>> At the time src/glx/apple/apple_glapi.c has been developed this patch was
>>> not needed I guess so I wonder which change made the regression.
>
>
> I'm not sure bisecting is going to work too well, as you might find it's
> apple-glx isn't buildable for most of the range, and you will probably land
> on a commit which say "rewrite glapi (again)" :D
>
True :'-(
If only we had more people to report things earlier/more often as things broke.


>> That's one way to get to the bottom of it. Alternatively we can take a
>> look at how other glx (indirect, xlib) handle it.
>
>
>> As is, the patch gets a big fat NACK, sorry.
>
>
> This smells to me like there's something not quite right about the
> partitioning of stuff between libmesa and libglapi, but I don't have any
> insight into what exactly the problem is.
>
Quite likely. Although it would be better to resolve it, as (if my
understanding is correct) libGL should not know anything about mesa's
internals. It ought to interact with DRI and glapi alone.

Mildly related:
Jon what happened to the applegl-vtable branches ? I really liked the
direction that they were going.

Thanks
Emil