[Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_FS_PROG_DATA in gen6_renderbuffer_surfaces.

Kenneth Graunke kenneth at whitecape.org
Mon Jul 6 13:40:00 PDT 2015

On Monday, July 06, 2015 12:18:18 PM Matt Turner wrote:
> On Mon, Jul 6, 2015 at 9:55 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > It looks like this was forgotten in commit 3c9dc2d31b80fc73bffa1f40a
> > (i965: Make a brw_stage_prog_data for storing the SURF_INDEX
> > information.)   In other words, it's been missing since we moved to
> > dynamic binding table slot assignments.
> Author:     Eric Anholt <eric at anholt.net>
> AuthorDate: Wed Oct 2 14:07:40 2013 -0700
> CommitDate: Tue Oct 15 10:18:42 2013 -0700
> Dang.
> How did you find this?

After reading Eero's latest performance analysis observations, I decided
to try marking render targets uncached (MOCS = UC) when blending and
logic ops (i.e. things that cause render target reads) are disabled.

This necessitated adding _NEW_COLOR.  Then I realized
BRW_NEW_FS_PROG_DATA was just plain missing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150706/c56dcc46/attachment-0001.sig>

More information about the mesa-dev mailing list