[Mesa-dev] [PATCH] nv50: fix a SIGSEGV with piglit bin/gl-3.1-vao-broken-attrib

Ilia Mirkin imirkin at alum.mit.edu
Mon Jul 6 16:56:48 PDT 2015

On Mon, Jul 6, 2015 at 7:55 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
>> >> +      } else
>> >> +      if (!vb->buffer) {
>> >
>> > Should the else and if be on the same line?
>> The general style elsewhere is to do it in this weird way. Can't say
>> I'm a big fan, but I prefer consistency.
>> I'd happily take a change that undid that oddity.
> Odd, okay.

Its one advantage is it allows one to easily remove clauses either
with #if or with comments on a line level without editing other lines.
However that's a pretty rare occurrence.

More information about the mesa-dev mailing list