[Mesa-dev] [PATCH] radeonsi: Use param export count from si_llvm_export_vs in si_shader_vs

Michel Dänzer michel at daenzer.net
Mon Jul 6 20:57:57 PDT 2015


On 06.07.2015 20:41, Marek Olšák wrote:
> I thought your patch does something else, but after re-reading it,
> it seems to do the right thing.

Yeah, si_llvm_export_vs's param_count only counts parameter exports.


> Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Thanks.


> On Mon, Jul 6, 2015 at 1:38 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> 
>> CLIPDIST is special in that it's exported twice, first as POS and
>> then as PARAM, the same will be done for CULLDIST in the future, so
>> these two should indeed be removed from the list.

With this change, you won't need to do anything in si_shader_vs when
making that change for CULLDIST, si_llvm_export_vs just needs to include
it in param_count.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the mesa-dev mailing list