[Mesa-dev] [PATCH 04/18] i965: Introduce a context-local batch manager

[Abdiel Janulgue]

On 07/07/2015 01:19 PM, Chris Wilson wrote:
> On Tue, Jul 07, 2015 at 01:14:53PM +0300, Abdiel Janulgue wrote:
>> On 07/06/2015 01:33 PM, Chris Wilson wrote:
>>> @@ -600,7 +593,10 @@ brw_emit_null_surface_state(struct brw_context *brw,
>>>  		  1 << BRW_SURFACE_WRITEDISABLE_B_SHIFT |
>>>  		  1 << BRW_SURFACE_WRITEDISABLE_A_SHIFT);
>>>     }
>>> -   surf[1] = bo ? bo->offset64 : 0;
>>> +   surf[1] = brw_batch_reloc(&brw->batch, *out_offset + 4,
>>> +                             bo, 0,
>>> +                             I915_GEM_DOMAIN_RENDER,
>>> +                             I915_GEM_DOMAIN_RENDER);
>>
>> null check for bo?
> 
> I put the NULL check into the inline variant of brw_batch_reloc() for a
> bit of syntatic sugar for these cases.
> -Chris
> 

You're, right. I failed to notice the in-line variant.