[Mesa-dev] [Mesa-stable] [PATCH] opencl: use versioned .so in mesa.icd

[Emil Velikov]

Ccing Tom

Thank you Igor !

On 07/07/15 11:05, Igor Gnatenko wrote:
> We must have versioned library in mesa.icd, because ICD loader would
> fail if the mesa-devel package wasn't installed.
> 
> Reported-by: Fabian Deutsch <fabian.deutsch at gmx.de>
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512
> Cc: "10.6" <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Igor Gnatenko <i.gnatenko.brain at gmail.com>
Similar to the default location of the .icd file, this is another picky
topic. Negardless I think we should go ahead with this patch.

Why ? First let's see what others do:
 - nvidia - versioned soname, resides in lib. The full soname is used.
 - catalyst - no soname, resides in lib. libamdocl32/64.so is used.
 - beignet - unversioned soname, resides in lib/foo. Full library path
is used and no version.
 - the spec - does not mention anything about soname, versioning or
location. The example gives a plain libVendorAOpenCL.so.
Based off this one can assume that it should live in lib, although
everything else remains open.

As our lovely build always sets SONAME (even when -module is set), the
Fedora guys are doing (have been shipping) it correctly.

With all that said, do we have any comments/objections against this patch ?

Thanks,
Emil