[Mesa-dev] [PATCH] nir: Fix comment above nir_convert_from_ssa() prototype.

Connor Abbott cwabbott0 at gmail.com
Wed Jul 8 06:36:37 PDT 2015


Whoops!

Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>

On Wed, Jul 8, 2015 at 1:57 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Presumably Connor renamed the parameter, inverting the sense.
> Update the comment accordingly.
>
> Cc: Connor Abbott <cwabbott0 at gmail.com>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/glsl/nir/nir.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
> index 4cb7d2f..9e2a281 100644
> --- a/src/glsl/nir/nir.h
> +++ b/src/glsl/nir/nir.h
> @@ -1659,9 +1659,9 @@ bool nir_ssa_defs_interfere(nir_ssa_def *a, nir_ssa_def *b);
>  void nir_convert_to_ssa_impl(nir_function_impl *impl);
>  void nir_convert_to_ssa(nir_shader *shader);
>
> -/* If convert_everything is true, convert all values (even those not involved
> - * in a phi node) to registers. If false, only convert SSA values involved in
> - * phi nodes to registers.
> +/* If phi_webs_only is true, only convert SSA values involved in phi nodes to
> + * registers.  If false, convert all values (even those not involved in a phi
> + * node) to registers.
>   */
>  void nir_convert_from_ssa(nir_shader *shader, bool phi_webs_only);
>
> --
> 2.4.5
>


More information about the mesa-dev mailing list