[Mesa-dev] [PATCH 04/18] i965: Introduce a context-local batch manager

[Chris Wilson]

On Wed, Jul 08, 2015 at 10:49:24AM -0700, Kenneth Graunke wrote:
> On Wednesday, July 08, 2015 03:17:35 PM Chris Wilson wrote:
> > On Wed, Jul 08, 2015 at 09:51:07AM +0100, Chris Wilson wrote:
> > > On Tue, Jul 07, 2015 at 10:03:09PM -0700, Kenneth Graunke wrote:
> > > > * Gen4-5 structure changes.
> > 
> > Did you mean brw_structs.h?
> > 
> > diff --git a/src/mesa/drivers/dri/i965/brw_structs.h b/src/mesa/drivers/dri/i965/brw_structs.h
> > index 55338c0..e167254 100644
> > --- a/src/mesa/drivers/dri/i965/brw_structs.h
> > +++ b/src/mesa/drivers/dri/i965/brw_structs.h
> > @@ -391,13 +391,16 @@ struct brw_sf_unit_state
> >        unsigned pad3:1;
> >     } thread4;
> >  
> > -   struct
> > +   union
> >     {
> > +      struct {
> >          unsigned front_winding:1;
> >          unsigned viewport_transform:1;
> >          unsigned pad0:3;
> >          unsigned sf_viewport_state_offset:27; /* Offset from GENERAL_STATE_BASE */
> >        } sf5;
> > +      uint32_t dw5;
> > +   };
> >  
> >     struct
> >     {
> > @@ -525,15 +528,17 @@ struct brw_wm_unit_state
> >     struct thread2 thread2;
> >     struct thread3 thread3;
> >  
> > +   union {
> >        struct {
> >          unsigned stats_enable:1;
> >          unsigned depth_buffer_clear:1;
> >          unsigned sampler_count:3;
> >          unsigned sampler_state_pointer:27;
> >        } wm4;
> > +      uint32_t dw4;
> > +   };
> >  
> > -   struct
> > -   {
> > +   struct {
> >        unsigned enable_8_pix:1;
> >        unsigned enable_16_pix:1;
> >        unsigned enable_32_pix:1;
> > diff --git a/src/mesa/drivers/dri/i965/brw_urb.c b/src/mesa/drivers/dri/i965/brw_urb.c
> > 
> > Or something else?
> > -Chris
> 
> Yes - and the changes are fine.  But...separable.

Would you like a patch to provide dword alternates for all the structs,
or just the ones used for relocation processing?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre