[Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

Michel Dänzer michel at daenzer.net
Wed Jul 8 20:45:38 PDT 2015

On 09.07.2015 02:07, Emil Velikov wrote:
> Most of the data stored(duplicated) was unused, and for the one that is
> follow the approach set by other drivers.
> This eliminates the use of legacy (dri1) types.

The commentary below should have been after the --- separator, not in
the actual Git commit log. With that fixed, this patch is

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>

> XXX: The radeon code is the only user of __DRIscreen::drm_version (the
> only __DRIversion outside of dri1 land). Should we move it into radeon
> and/or bump the min. required drm module version ?

Moving this into radeon sounds good to me, but I'm not sure what exactly
you mean by bumping the minimum required version, or what it's supposed
to be good for.

FWIW though, any code which is specific to radeon DRM major version 1
can be removed, because that's the UMS major version.

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the mesa-dev mailing list