[Mesa-dev] [PATCH 03/11] radeon: remove dri_mirror state

[Marek Olšák]

"major != 2" can't occur. You don't have to check the major version at
all and you can just assume it's always 2.

Marek

On Thu, Jul 9, 2015 at 2:55 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 9 July 2015 at 04:45, Michel Dänzer <michel at daenzer.net> wrote:
>> On 09.07.2015 02:07, Emil Velikov wrote:
>>> Most of the data stored(duplicated) was unused, and for the one that is
>>> follow the approach set by other drivers.
>>> This eliminates the use of legacy (dri1) types.
>>
>> The commentary below should have been after the --- separator, not in
>> the actual Git commit log. With that fixed, this patch is
>>
>> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>>
>>
>>> XXX: The radeon code is the only user of __DRIscreen::drm_version (the
>>> only __DRIversion outside of dri1 land). Should we move it into radeon
>>> and/or bump the min. required drm module version ?
>>
>> Moving this into radeon sounds good to me, but I'm not sure what exactly
>> you mean by bumping the minimum required version, or what it's supposed
>> to be good for.
>>
>> FWIW though, any code which is specific to radeon DRM major version 1
>> can be removed, because that's the UMS major version.
>>
> Here is what we have atm.
>
> radeon/r200_context.c:
>
> if (major == 1 && minor < 13)
>  printf("boho no hyperz for you\n")
> }
>
> if (minor >=15) // major check anyone ?
>  r_context.texmicrotile = true; // unused since 2009
> ccf7814a315(radeon: major cleanups removing old dead codepaths.)
>
>
> radeon_screen.c:
>
> if (major >= 2)
>  drmCommandReadWrite(DRM_RADEON_INFO)
> else
>  drmCommandReadWrite(DRM_RADEON_GETPARAM)
>
> Considering the amdgpu work (major number), I think we can just error
> out if major !=2 and cleanup the above ?
>
> Cheers,
> Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev