[Mesa-dev] [PATCH] [v3] i965: Split out gen8 push constant state upload
baker.dylan.c at gmail.com
Mon Jul 13 15:44:51 PDT 2015
On Fri, Jul 10, 2015 at 02:24:42PM -0700, Ben Widawsky wrote:
> On Fri, Jul 10, 2015 at 12:03:54PM -0700, Matt Turner wrote:
> > I don't think putting Intel-internal links in the commit message is a good idea.
> > Ken's made similar comments to me.
> > Also, so much off the wall commentary...
> Maybe my definition of "off the wall" is different than yours. The only thing
> off the wall to me, was the bit about missing Mark. It was *some* off the wall
> That aside though, I think the internal links is a good point and thing to
> discuss... I've had a couple of cases already where I, or Neil benefited from
> the Jenkins links being there to try to figure out some later regression. I can
> sympathize with not having internal links in the history since it isn't
> accessible to anyone. Earlier, I would have fought somewhat strongly for the
> links, except that when Mark moved servers he didn't preserve the old links, so
> that made me feel like it's a lot more transient than I initially felt.
> However, I think it's really valuable for us to have them in the patches,
> especially for review by some of the internal folks - like isn't it great to see
> for yourself that I ran it? I suppose I can discard the URLs before pushing. The
> cases I mentioned above would have benefited just as well having the links on
> the list and not in the commit history (albeit a bit harder to find). Any
> opposition to that?
It's worth pointing out in this discussion that old results are pruned
after so many days. It's simply not practical for us to store all of the
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 473 bytes
Desc: Digital signature
More information about the mesa-dev