[Mesa-dev] [PATCH 1/2] i965/cs: Setup push constant data for uniforms

[Jordan Justen]

On 2015-07-09 17:15:14, Ben Widawsky wrote:
> On Tue, Jun 16, 2015 at 02:21:39PM -0700, Jordan Justen wrote:
> > +static void
> > +gen7_upload_cs_push_constants(struct brw_context *brw)
> > +{
> > +   struct brw_stage_state *stage_state = &brw->cs.base;
> > +
> > +   /* BRW_NEW_COMPUTE_PROGRAM */
> > +   const struct brw_compute_program *cp =
> > +      (struct brw_compute_program *) brw->compute_program;
> > +
> > +   if (cp) {
> > +      /* CACHE_NEW_CS_PROG */
> > +      struct brw_cs_prog_data *cs_prog_data = brw->cs.prog_data;
> > +
> > +      brw_upload_cs_push_constants(brw, &cp->program.Base, cs_prog_data,
> > +                                   stage_state, AUB_TRACE_WM_CONSTANTS);
> 
> I'm uncertain, but I wonder if we need to flag that you've destroyed the URB
> state like it's done in gen7_push_constant_space state atom.

I tried looking for some documentation that indicated if compute's
usage of the URB would invalidate the render URB allocations/state,
but I didn't see anything...

-Jordan