[Mesa-dev] [PATCH] mesa: allow GL_TEXTURE_CUBE_MAP_ARRAY case for glCompressedTexSubImage3D()

[Roland Scheidegger]

Could mention this is actually a gl spec bug in the commit message, but
either way:

Reviewed-by: Roland Scheidegger <sroland at vmware.com>


Am 21.07.2015 um 22:55 schrieb Brian Paul:
> Since s3tc works for cube maps and 2D arrays, it should also work for
> cube arrays.  NVIDIA's driver supports this too.  This is a minor follow-on
> fix for the commit "mesa: fix up some texture error checks".
> ---
>  src/mesa/main/teximage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index 842b50d..6aa1bb4 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
> @@ -4588,7 +4588,7 @@ compressed_subtexture_target_check(struct gl_context *ctx, GLenum target,
>         * are valid here, which they are not, but of course not mentioned by
>         * core spec.
>         */
> -      if (target != GL_TEXTURE_2D_ARRAY) {
> +      if (target != GL_TEXTURE_2D_ARRAY && target != GL_TEXTURE_CUBE_MAP_ARRAY) {
>           bool invalidformat;
>           switch (format) {
>              /* These came from _mesa_is_compressed_format in glformats.c. */
>