[Mesa-dev] [PATCH 28/46] glsl: don't lower variable indexing on non-patch tessellation inputs/outputs

[Dave Airlie]

On 17 July 2015 at 06:15, Marek Olšák <maraeo at gmail.com> wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> There is no way to lower them, because the array sizes are unknown
> at compile time.
>
> Based on a patch from: Fabian Bieler <fabianbieler at fastmail.fm>
>
> v2: add comments

you added the comment but you typoed it.


> +
>        case ir_var_shader_in:
> +         /* The input array size is unknown at compiler time for non-patch
> +          * inputs in TCS and TES. The arrays are sized to
> +          * the implementation-dependent limit "gl_MaxPatchVertices", but
> +          * the real size is stored in the "gl_PatchVerticeIn" built-in

gl_PatchVerticeIn?

Other than that,

Reviewed-by: Dave Airlie <airlied at redhat.com>