[Mesa-dev] [PATCH 09/21] nir/cf: handle phi nodes better in split_block_beginning()

Connor Abbott cwabbott0 at gmail.com
Tue Jul 21 19:54:23 PDT 2015


Signed-off-by: Connor Abbott <connor.w.abbott at intel.com>
---
 src/glsl/nir/nir_control_flow.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/glsl/nir/nir_control_flow.c b/src/glsl/nir/nir_control_flow.c
index 205b608..b416a58 100644
--- a/src/glsl/nir/nir_control_flow.c
+++ b/src/glsl/nir/nir_control_flow.c
@@ -210,6 +210,19 @@ split_block_beginning(nir_block *block)
       link_blocks(pred, new_block, NULL);
    }
 
+   /* Any phi nodes must stay part of the new block, or else their
+    * sourcse will be messed up. This will reverse the order of the phi's, but
+    * order shouldn't matter.
+    */
+   nir_foreach_instr_safe(block, instr) {
+      if (instr->type != nir_instr_type_phi)
+         break;
+
+      exec_node_remove(&instr->node);
+      instr->block = new_block;
+      exec_list_push_head(&new_block->instr_list, &instr->node);
+   }
+
    return new_block;
 }
 
-- 
2.4.3



More information about the mesa-dev mailing list