[Mesa-dev] [PATCH 1/2] mesa: adjust error message when there's a missing teximage

[Brian Paul]

On 07/22/2015 11:02 AM, Ilia Mirkin wrote:
> The current message makes it seem like the zoffset is invalid.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>   src/mesa/main/texgetimage.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
> index 59ec091..2f35ac6 100644
> --- a/src/mesa/main/texgetimage.c
> +++ b/src/mesa/main/texgetimage.c
> @@ -1013,8 +1013,7 @@ dimensions_error_check(struct gl_context *ctx,
>      texImage = select_tex_image(texObj, target, level, zoffset);
>      if (!texImage) {
>         /* missing texture image */
> -      _mesa_error(ctx, GL_INVALID_OPERATION,
> -                  "%s(zoffset = %d)", caller, zoffset);
> +      _mesa_error(ctx, GL_INVALID_OPERATION, "%s(missing image)", caller);
>         return true;
>      }
>
>

Reviewed-by: Brian Paul <brianp at vmware.com>