[Mesa-dev] [PATCH] mesa: fix _mesa_error() compiler warnings in shaderapi.c

Kai Wasserbäch kai at dev.carbon-project.org
Thu Jul 23 13:13:14 PDT 2015

Brian Paul wrote on 07/23/2015 03:58 PM:
> Fix many instances of:
> main/shaderapi.c: In function '_mesa_GetSubroutineUniformLocation':
> main/shaderapi.c:2176:7: warning: format not a string literal and no format arguments [-Wformat-security]
>        _mesa_error(ctx, GL_INVALID_OPERATION, api_name);
>        ^
> Ideally, many of these error messages should be improved to indicate
> which argument is incorrect as we do in other parts of Mesa.

Reviewed-by: Kai Wasserbäch <kai at dev.carbon-project.org>
Tested-by: Kai Wasserbäch <kai at dev.carbon-project.org>

Thanks, this broke my build (with a -Werror=format-security from Debian's
default build flags).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 630 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150723/c3a5ca27/attachment.sig>

More information about the mesa-dev mailing list