[Mesa-dev] [PATCH 04.5/12] i965/fs: Fix misleading comment regarding the message header in emit_texture_gen7.

[Jason Ekstrand]

R-B me
On Jul 24, 2015 6:52 AM, "Francisco Jerez" <currojerez at riseup.net> wrote:

> This hasn't been overallocating space for the header for a long time.
> It still leaves the header uninitialized though until the generator
> fixes it.
> ---
>  src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> index 09beb4d..5977f6d 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> @@ -473,8 +473,9 @@ fs_visitor::emit_texture_gen7(ir_texture_opcode op,
> fs_reg dst,
>     if (op == ir_tg4 || offset_value.file != BAD_FILE ||
>         is_high_sampler(devinfo, sampler)) {
>        /* For general texture offsets (no txf workaround), we need a
> header to
> -       * put them in.  Note that for SIMD16 we're making space for two
> actual
> -       * hardware registers here, so the emit will have to fix up for
> this.
> +       * put them in.  Note that we're only reserving space for it in the
> +       * message payload as it will be initialized implicitly by the
> +       * generator.
>         *
>         * * ir4_tg4 needs to place its channel select in the header,
>         * for interaction with ARB_texture_swizzle
> --
> 2.4.3
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150724/948f62b0/attachment.html>