[Mesa-dev] [Bug 91496] [clover] Multiple device probe fails since a27ec5dc460b91dc44675f48cddbbb2631ee824f

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91496

            Bug ID: 91496
           Summary: [clover] Multiple device probe fails since
                    a27ec5dc460b91dc44675f48cddbbb2631ee824f
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Other
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: jay at jcornwall.me
        QA Contact: mesa-dev at lists.freedesktop.org

This commit:

pipe-loader: simplify pipe_loader_drm_probe
Do not iterate and (attempt to) open the render device, if we're over
the requested number of devices.

Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
Reviewed-by: Francisco Jerez <currojerez at riseup.net>

Appears to break the pipe_loader_probe API:

/**
 * Get a list of known devices.
 *
 * \param devs Array that will be filled with pointers to the devices
 *             available in the system.
 * \param ndev Maximum number of devices to return.
 * \return Number of devices available in the system.
 */
int
pipe_loader_probe(struct pipe_loader_device **devs, int ndev);

clover/core/platform.cpp relies on pipe_loader_probe(NULL, 0) to obtain the
number of devices available. A fixed upper bound on device count doesn't seem
ideal.

It currently appears to work for a single device because pipe_loader_sw_probe
returns 1 and this is subsequently used to retrieve the device from
pipe_loader_drm_probe.

I think a revert of the above commit is the only way to fulfill this API.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150728/0f4ebed9/attachment.html>