[Mesa-dev] [PATCH] svga: scons: remove unused HAVE_SYS_TYPES_H define

Emil Velikov emil.l.velikov at gmail.com
Wed Jul 29 09:39:37 PDT 2015


On 28 July 2015 at 14:37, Brian Paul <brianp at vmware.com> wrote:
> On 07/28/2015 07:33 AM, Emil Velikov wrote:
>>
>> On 20 July 2015 at 17:12, Brian Paul <brianp at vmware.com> wrote:
>>>
>>> On 07/17/2015 02:14 PM, Emil Velikov wrote:
>>>>
>>>>
>>>> On 17 July 2015 at 20:22, Brian Paul <brianp at vmware.com> wrote:
>>>>>
>>>>>
>>>>> Can you elaborate in the commit message why this is being done or why
>>>>> the
>>>>> HAVE_SYS_TYPES_H definition is not needed?  That saves me time having
>>>>> to
>>>>> research the issue myself.
>>>>>
>>>> I'm not sure I can elaborate more than "it's unused" without sounding
>>>> too repetitive. I can add "There isn't a single instance in mesa that
>>>> mentions HAVE_SYS_TYPES_H, other than this file." if it makes it
>>>> better.
>>>
>>>
>>>
>>> Ugh, I read it as "remove HAVE_SYS_TYPES_H define".  Thanks.
>>>
>> Can I consider this acked-by with the above commit message ? Would you
>> like me to resend ?
>
>
> Sure, Acked-by.  Sorry for not being clear.
>
Sweet, thanks !

-Emil


More information about the mesa-dev mailing list