[Mesa-dev] [PATCH 1/6] egl/x11: bail out if we cannot fetch the xcb connection

Matt Turner mattst88 at gmail.com
Wed Jul 29 10:17:16 PDT 2015

On Wed, Jul 29, 2015 at 9:19 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Strictly speaking the xcb_connection_has_error() might be sufficient,
> yet the documentation does not mention what will happen if NULL is fed
> to the function.
> Keep things explicit, which will allow us to remove the dri2_dpy->conn
> checking with the next commit.

Its implementation is

int xcb_connection_has_error(xcb_connection_t *c)
    /* doesn't need locking because it's read and written atomically. */
    return c->has_error;

so passing NULL is certainly not okay. :)

More information about the mesa-dev mailing list