[Mesa-dev] [PATCH] mesa/st/xformfb: drop assert(0) that can get hit from API

[Marek Olšák]

If glDrawTransformFeedback is called with no recorded vertices, the
whole draw call should be dropped, because vertex count == 0, right?

Marek

On Thu, Jul 30, 2015 at 2:52 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> The API can hit this, as the ogl confirm suite showed, I've
> sent a piglit test to also demonstrate hitting it.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/mesa/state_tracker/st_cb_xformfb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_cb_xformfb.c b/src/mesa/state_tracker/st_cb_xformfb.c
> index 07c118e..925fbd4 100644
> --- a/src/mesa/state_tracker/st_cb_xformfb.c
> +++ b/src/mesa/state_tracker/st_cb_xformfb.c
> @@ -191,7 +191,6 @@ st_transform_feedback_get_draw_target(struct gl_transform_feedback_object *obj)
>        }
>     }
>
> -   assert(0);
>     return NULL;
>  }
>
> --
> 2.4.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev