[Mesa-dev] [PATCH] includes/GL: remove duplicated extension declarations from glx.h

[Ian Romanick]

On 07/30/2015 07:50 AM, Emil Velikov wrote:
> On 30 July 2015 at 15:22, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> All three of GLX_NV_float_buffer, GLX_EXT_texture_from_pixmap and
>> GLX_MESA_query_renderer have been in glxext.h for a while now.
>>
>> As such we can drop this workaround/hack from the header.
>>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>
>> Not to mention that glxext.h honours GLX_GLXEXT_PROTOTYPES and provides
>> the relevant typedefs and/or function declarations when appropriate.
>>
>> -Emil
>>
>>  include/GL/glx.h | 88 --------------------------------------------------------
>>  1 file changed, 88 deletions(-)
>>
>> diff --git a/include/GL/glx.h b/include/GL/glx.h
>> index 78f5052..d612b79 100644
>> --- a/include/GL/glx.h
>> +++ b/include/GL/glx.h
>> @@ -371,14 +371,6 @@ extern Bool glXDrawableAttribARB(Display *dpy, GLXDrawable draw, const int *attr
>>  /*
>>   * Remove this when glxext.h is updated.
>>   */
> Seems like I should drop this comment as well.
> 
> On a related note: there are a few more extensions that never made it
> (i.e. are missing from the Khronos public spec page) but are still
> around.
> 
> Namely
> GLX_NV_vertex_array_range
> - Shipped with nvidia's glxext.h, but unused in the binary driver
> (version 352.21).
> - Referenced in GLX_MESA_agp_offset - "GLX_NV_vertex_array_range is required"
> 
> GLX_ARB_render_texture
> - No hints in nvidia headers/binary.
> - Referenced in GLX_EXT_texture_from_pixmap -  "Adapted spec language
> from draft version of GLX_ARB_render_texture"
> - The Khronos meeting minutes state "GLX_ARB_render_texture hasn't
> been kept up to date, but there's no reason it can't be completed."
> [1]
> 
> GLX_MESA_swap_frame_usage
> - No hints in nvidia headers/binary.
> - No reference to in the public specs.
> 
> GLX_MESA_swap_control
> - No hints in nvidia headers/binary.
> - Referenced by GLX_EXT_swap_control, "Based on GLX_MESA_swap_control
> version 1.1"

I think both of these have specs in the Mesa tree.

> I'm not suggesting that we should nuke these, but curious if they are
> or may have been used at some point.
> 
> -Emil
> 
> [1] https://www.opengl.org/archives/about/arb/meeting_notes/notes/meeting_note_2001-06-12.html
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>