[Mesa-dev] [PATCH 3/3] dri: set the __DRI_API_OPENGL bit based on max gl compat version

Emil Velikov emil.l.velikov at gmail.com
Thu Jul 30 09:16:58 PDT 2015


On 30 July 2015 at 10:27, Frank Binns <frank.binns at imgtec.com> wrote:
> This matches similar behaviour for the __DRI_API_OPENGL_CORE bit.
>
> Signed-off-by: Frank Binns <frank.binns at imgtec.com>
> ---
>  src/mesa/drivers/dri/common/dri_util.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c
> index 884a7e0..d35ac26 100644
> --- a/src/mesa/drivers/dri/common/dri_util.c
> +++ b/src/mesa/drivers/dri/common/dri_util.c
> @@ -163,7 +163,9 @@ driCreateNewScreen2(int scrn, int fd,
>         }
>      }
>
> -    psp->api_mask = (1 << __DRI_API_OPENGL);
> +    psp->api_mask = 0;
> +    if (psp->max_gl_compat_version > 0)
> +       psp->api_mask |= (1 << __DRI_API_OPENGL);
It's almost as if there is a DRI module that doesn't do OpenGL but
GLES alone (cough, cough).

But seriously, the series looks great imho, and is Reviewed-by: Emil
Velikov <emil.l.velikov at gmail.com>

I do wonder if we should pull patch#1 (and #2) for the stable branch ?

-Emil


More information about the mesa-dev mailing list