[Mesa-dev] [PATCH 1/3] egl/x11: fix use of EGL_BAD_NATIVE_WINDOW

[Emil Velikov]

On 31 July 2015 at 11:02, Frank Binns <frank.binns at imgtec.com> wrote:
> Commit 4ed23fd590 introduced some calls to _eglError inappropriately
> passing it EGL_BAD_NATIVE_WINDOW. This was actually harmless in two of the
> cases as _eglError gets called later on with a more appropriate error code
> but (just to be safe) switch these to _eglLog calls instead. In the
> remaining case, change the error to EGL_BAD_ALLOC instead as this seems
> more appropriate.
>
Hmm... EGL_BAD_NATIVE_WINDOW might not be the best, but EGL_BAD_ALLOC
doesn't seem much better.

There is no memory allocation happening there, so I'm not sure why you
believe it more appropriate. I'm wondering about EGL_BAD_PARAMETER,
yet it's very unlikely we'll ever get here. Did you see any uses that
trigger this ?

-Emil