[Mesa-dev] [Mesa-dev, 1/9] mesa/es3.1: Allow binding GL_DRAW_INDIRECT_BUFFER with gles 3.1

[Lofstedt, Marta]

Thanks Tapani,

However, 

For patch 9 there is a V3 for which I can't see any new objections:
http://patchwork.freedesktop.org/patch/51879/

If you have any new ones could you please clarify.

My interpretation of the comments on patch 6, is that it was OK as it is. 
Please clarify if you don't agree.

> -----Original Message-----
> From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On
> Behalf Of Tapani Pälli
> Sent: Friday, July 31, 2015 10:28 AM
> To: Marta Löfstedt; mesa-dev at lists.freedesktop.org
> Subject: Re: [Mesa-dev] [Mesa-dev, 1/9] mesa/es3.1: Allow binding
> GL_DRAW_INDIRECT_BUFFER with gles 3.1
> 
> I've gone through this set (and using them regularly to be able to run 3.1es
> conformance tests);
> 
> Patches 1,2,3,4,5,7,8
> 
> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
> 
> I believe with 6 and 9 there are changes required.
> 
> On 05/11/2015 04:03 PM, Marta Löfstedt wrote:
> > From: Marta Lofstedt <marta.lofstedt at intel.com>
> >
> > Signed-off-by: Marta Lofstedt <marta.lofstedt at intel.com>
> >
> > ---
> > src/mesa/main/bufferobj.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> > index 66dee68..07f82cd 100644
> > --- a/src/mesa/main/bufferobj.c
> > +++ b/src/mesa/main/bufferobj.c
> > @@ -91,8 +91,9 @@ get_buffer_target(struct gl_context *ctx, GLenum
> target)
> >      case GL_COPY_WRITE_BUFFER:
> >         return &ctx->CopyWriteBuffer;
> >      case GL_DRAW_INDIRECT_BUFFER:
> > -      if (ctx->API == API_OPENGL_CORE &&
> > -          ctx->Extensions.ARB_draw_indirect) {
> > +      if ((ctx->API == API_OPENGL_CORE &&
> > +           ctx->Extensions.ARB_draw_indirect) ||
> > +           _mesa_is_gles31(ctx)) {
> >            return &ctx->DrawIndirectBuffer;
> >         }
> >         break;
> >
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
----------------------------------------------------------------------
Intel Sweden AB
Registered Office: Knarrarnasgatan 15, 164 40 Kista, Stockholm, Sweden
Registration Number: 556189-6027

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.