[Mesa-dev] [PATCH 14/18] util/register_allocate: Compute transitive conflicts using 2-passes
chris at chris-wilson.co.uk
Fri Jul 31 09:38:05 PDT 2015
On Fri, Jul 31, 2015 at 09:30:36AM -0700, Jason Ekstrand wrote:
> This patch looks really sketchy to me. First, you fundamentally
> changed some of register_allocate's internal data structures with no
> explanation as to what the change is and why it still works. Maybe
> the difference should be obvious to me, but it isn't. Second, it
> appears that your changes assume some intel-specific details of
> register allocation. The register_allocate code is *not* Intel
> specific and we are *not* the only ones using it.
You'll note the generic interface is maintained and the custom interface
for Intel is where our overhead lies. And yes, we are the only ones
using this interface.
Chris Wilson, Intel Open Source Technology Centre
More information about the mesa-dev