[Mesa-dev] [PATCH] r600: Remove assert that not general in some stream instr's

Edward O'Callaghan edward.ocallaghan at koparo.com
Fri Jul 31 17:53:38 PDT 2015


Ah, oh! I see, yes I was trying to work out how to polish off GL4 for
r600 too.

Alright, I guess you have my review on that part then :p is moving
VGT_STRMOUT_BUFFER_CONFIG the only part of those patches that needs to
be fixed up before they can be merged?

Cheers,
Edward.

-- 
  Edward O'Callaghan
  edward.ocallaghan at koparo.com

On Fri, Jul 31, 2015, at 12:47 PM, Dave Airlie wrote:
> seems like one I wrote already..
> http://lists.freedesktop.org/archives/mesa-dev/2015-July/088404.html
> 
> Dave.
> 
> On 31 July 2015 at 12:42, Edward O'Callaghan
> <eocallaghan at alterapraxis.com> wrote:
> > Don't trigger assert on some stream emit instructions.
> >
> > Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
> > ---
> >  src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp b/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp
> > index 8c2cd14..48d56ac 100644
> > --- a/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp
> > +++ b/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp
> > @@ -761,8 +761,6 @@ void bc_finalizer::finalize_cf(cf_node* c) {
> >                         mask |= (1 << chan);
> >                 }
> >
> > -               assert(reg >= 0 && mask);
> > -
> >                 if (reg >= 0)
> >                         update_ngpr(reg);
> >
> > --
> > 2.4.3
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list