[Mesa-dev] [PATCH 0/6] egl: Drop non-c99 keywords - INLINE, __FUNCTION__

[Emil Velikov]

On 28/02/15 18:00, Matt Turner wrote:
> On Sat, Feb 28, 2015 at 9:48 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> Here is to another round of cleanups :-)
> 
> The series is
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> 
Thanks. I'll give it a couple of days for any comments/objections and
push the lot.

>> Namely we drop the use and definition of INLINE, __FUNCTION__ and use
>> their c99 brothers.
>>
>> Patch 3 hides the internal _egl* symbols, which is no longer needed
>> since we disabled st/egl. We might want to have this patch in 10.5 but
>> I won't push on it.
> 
> Let's put it in 10.5, since I think there's a good chance it'll fix
> this bug [0], which manifests when applications linked against Mesa's
> libEGL (with extra symbols) try to run against NVIDIA's libEGL.
> 
> [0] https://bugs.gentoo.org/show_bug.cgi?id=501328
> 
Rafał Mużyło analysis seems to be on the spot. llvm-config --ldflags
does produce some weird stuff, which we don't handle too well.

Perhaps as we get into clearing up the llvm handling (or our
configure.ac) we can double check. Until then this will do :-)


Cheers
Emil