[Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

Sedat Dilek sedat.dilek at gmail.com
Sun Mar 1 09:02:27 PST 2015


On Sun, Mar 1, 2015 at 5:45 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 01/03/15 14:09, Marc Dietrich wrote:
>> This patch simplifies the visibility compiler flag detection in configure and
>> makes it more generic to also support compilers other than gcc.
>>
>> Cc: Emil Velikov <emil.l.velikov at gmail.com>
>> Signed-off-by: Marc Dietrich <marvin24 at gmx.de>
>>
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>
> Looks great thank you. I'm assuming that you're short on commit access
> so I'm push this around Wednesday, unless there are further comments.
>

Where is the 2/2 of this patch?
Alone it does not work with LLVM/Clang v3.6.0 with mesa v10.4.5.
If there is an additional patch, please point me to it.

$ grep -i visibility
logs/build-and-install-log_mesa-10-4-5_gallivm-fixes_mapi-tls-fixes_visibility-compiler-flag-detection_enable-glx-tlsllvm-3-6-0.txt
checking for __attribute__((visibility))... yes


Otherwise, feel free to add my...

     Tested-by: Sedat Dilek <sedat.dilek at gmail.com>

- Sedat -


More information about the mesa-dev mailing list