[Mesa-dev] [PATCH 2/2] configure: Leverage gcc warn options to enable safe use of C99 features where possible.

[Kenneth Graunke]

On Monday, March 02, 2015 03:24:18 PM Jose Fonseca wrote:
> On 28/02/15 00:25, Kenneth Graunke wrote:
> > On Friday, February 27, 2015 09:58:51 PM Jose Fonseca wrote:
> >> Sorry, this didn't pop up when I built it here.  And I'm afraid I won't have time to look into this today, and possibly the weekend.
> >>
> >> If there's not an obvious fix feel free to push a commit commiting out the  .MSVC2013_COMPAT_*FLAGS= in configure.ac
> >>
> >> I'll act on other reviews too as soon as I can.
> >>
> >> Jose
> >
> > Strange.  It didn't pop up when I tried it either - maybe I failed to do
> > a clean build.  But I'm definitely hitting the same breakage, with these
> > flags:
> >
> > git clean -fdx; CFLAGS='-g -fno-omit-frame-pointer' CXXFLAGS='-g -fno-omit-frame-pointer' ./autogen.sh --enable-gles2 --enable-glx-tls --with-egl-platforms=x11,drm --with-gallium-drivers= --with-dri-drivers=i965 --enable-debug
> >
> > Ben also hit this.
> >
> > I've reverted the patch for now - hopefully we can land a v2 soon.
> >
> 
> I believe that Matt's change 
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=76cd0f00f44c0935dc7d6a0e14e0515f08a8e1dc 
> should fix this.
> 
> Those who hit the issue, could you please re-apply 
> 79daa510c7a871a33797308a2ccb4b83a067ffbe if that was the end of it or 
> whether there are more errors?
> 
> Jose
> 

I tested {debug,release} x {64-bit,32-bit} builds, using git clean -fdx each time.
They all appear to work fine for me.

Sorry for the trouble - I didn't realize the fix would be so tiny.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150302/1d6169b3/attachment.sig>