[Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

[Brian Paul]

On 03/02/2015 03:48 PM, Kenneth Graunke wrote:
> Generated by the following Coccinelle semantic patch:
>
> @@
> expression E;
> @@
> if (
> -E
> +unlikely(E)
>   )
> { ... _mesa_error(...) ... }
>
> Improves performance in OglBatch7 (a CPU-bound microbenchmark) on
> an i7 4750HQ (Haswell) by 1.08546% +/- 0.519734% (n=292).
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

I like it.  But I have to say, when I first proposed doing this last 
year (IIRC) someone poo-pood it.  I don't remember who.

Acked-by: Brian Paul <brianp at vmware.com>