[Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

[Kenneth Graunke]

On Monday, March 02, 2015 02:33:31 PM Ilia Mirkin wrote:
> On Mon, Mar 2, 2015 at 2:32 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> >
> >
> > On Mon, Mar 2, 2015 at 11:18 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> >>
> >> Hmmm... I was just looking at this code in connection to attepmting to
> >> enable ARB_texture_stencil8, and it _seems_ like that should be if
> >> (ARB_texture_stencil8) -- I didn't see what in ARB_stencil_texturing
> >> had to do with being able to have a GL_STENCIL_INDEX* internal
> >> format...
> >
> >
> > I just pushed it because it does fix a bug...  However, you do raise a good
> > point.  Maybe we should change the i965 driver to use GL_STENCIL_INDEX for
> > the internal format for our internal stencil buffers.
> 
> How do you end up with a GL_STENCIL_INDEX internal format in the first
> place? Without ARB_texture_stencil8 that's not a thing, is it?

Eric added a ctx->Driver.BindRenderbufferTexImage hook which takes a
(non-texture) renderbuffer and wraps it in a fake texture image.

We use this in Meta's BlitFramebuffer implementation to be able to blit
from non-texture renderbuffers.  i965 also has a custom meta blit path
for stencil, which uses the same approach.  Thus, stencil textures :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150303/86fa8861/attachment.sig>