[Mesa-dev] [PATCH] gallium/auxiliary/indices: fix start param

[Ilia Mirkin]

On Fri, Feb 27, 2015 at 1:40 PM, Marc-André Lureau
<marcandre.lureau at gmail.com> wrote:
> Since commit 28f3f8d, indices generator take a start parameter. However, some
> index values have been left to start at 0.
>
> This fixes the glean/fbo test with the virgl driver.

I independently arrived at an identical patch when trying to figure
out why freedreno was messed up.

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

> ---
>  src/gallium/auxiliary/indices/u_indices_gen.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/gallium/auxiliary/indices/u_indices_gen.py b/src/gallium/auxiliary/indices/u_indices_gen.py
> index 2714df8..f05b70a 100644
> --- a/src/gallium/auxiliary/indices/u_indices_gen.py
> +++ b/src/gallium/auxiliary/indices/u_indices_gen.py
> @@ -193,7 +193,7 @@ def lineloop(intype, outtype, inpv, outpv):
>      print '  for (i = start, j = 0; j < nr - 2; j+=2, i++) { '
>      do_line( intype, outtype, 'out+j',  'i', 'i+1', inpv, outpv );
>      print '   }'
> -    do_line( intype, outtype, 'out+j',  'i', '0', inpv, outpv );
> +    do_line( intype, outtype, 'out+j',  'i', 'start', inpv, outpv );
>      postamble()
>
>  def tris(intype, outtype, inpv, outpv):
> @@ -218,7 +218,7 @@ def tristrip(intype, outtype, inpv, outpv):
>  def trifan(intype, outtype, inpv, outpv):
>      preamble(intype, outtype, inpv, outpv, prim='trifan')
>      print '  for (i = start, j = 0; j < nr; j+=3, i++) { '
> -    do_tri( intype, outtype, 'out+j',  '0', 'i+1', 'i+2', inpv, outpv );
> +    do_tri( intype, outtype, 'out+j',  'start', 'i+1', 'i+2', inpv, outpv );
>      print '   }'
>      postamble()
>
> @@ -228,9 +228,9 @@ def polygon(intype, outtype, inpv, outpv):
>      preamble(intype, outtype, inpv, outpv, prim='polygon')
>      print '  for (i = start, j = 0; j < nr; j+=3, i++) { '
>      if inpv == FIRST:
> -        do_tri( intype, outtype, 'out+j',  '0', 'i+1', 'i+2', inpv, outpv );
> +        do_tri( intype, outtype, 'out+j',  'start', 'i+1', 'i+2', inpv, outpv );
>      else:
> -        do_tri( intype, outtype, 'out+j',  'i+1', 'i+2', '0', inpv, outpv );
> +        do_tri( intype, outtype, 'out+j',  'i+1', 'i+2', 'start', inpv, outpv );
>      print '   }'
>      postamble()
>
> --
> 2.1.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev