[Mesa-dev] [PATCH, v2 2/2] r300g: Fix build, invalid extern "C" around header inclusion.

Jose Fonseca jfonseca at vmware.com
Fri Mar 6 14:31:49 PST 2015


On 06/03/15 21:36, Mark Janes wrote:
> A previous patch to fix header inclusion within extern "C" neglected
> to fix the occurences of this pattern in r300 files.
>
> When the helper to detect this issue was pushed to master, it broke
> the build for the r300 driver.  This patch fixes the r300 build.
>
> Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D89477&d=AwIBAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=6WnEXtdaOJqFnP3S0oc26QXxj8uo7JiEsuTzTY8zI6k&s=bvcOVf9VAs3kS_SGoZ1n9CpV3dgWtcJyn4MskAdNNhc&e=
> ---
>   src/gallium/drivers/r300/r300_public.h | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/src/gallium/drivers/r300/r300_public.h b/src/gallium/drivers/r300/r300_public.h
> index b605920..57a69cb 100644
> --- a/src/gallium/drivers/r300/r300_public.h
> +++ b/src/gallium/drivers/r300/r300_public.h
> @@ -2,8 +2,16 @@
>   #ifndef R300_PUBLIC_H
>   #define R300_PUBLIC_H
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>   struct radeon_winsys;
>
>   struct pipe_screen* r300_screen_create(struct radeon_winsys *rws);
>
> +#ifdef __cplusplus
> +} // extern "C"
> +#endif
> +
>   #endif
>

Series looks good to me too. Thanks.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>


More information about the mesa-dev mailing list