[Mesa-dev] [PATCH v2] nv30: Add unused attribute to function nv40_fp_bra.

[Francisco Jerez]

Matt Turner <mattst88 at gmail.com> writes:

> On Fri, Mar 6, 2015 at 11:43 PM, Vinson Lee <vlee at freedesktop.org> wrote:
>> Silences GCC unused-function warning.
>>
>> nv30/nvfx_fragprog.c:333:1: warning: ‘nv40_fp_bra’ defined but not used [-Wunused-function]
>>  nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target)
>>  ^
>>
>> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
>> ---
>>  src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c b/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c
>> index 6600997..abd51c8 100644
>> --- a/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c
>> +++ b/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c
>> @@ -329,7 +329,7 @@ nv40_fp_rep(struct nvfx_fpc *fpc, unsigned count, unsigned target)
>>  }
>>
>>  /* warning: this only works forward, and probably only if not inside any IF */
>> -static void
>> +static __attribute__((unused)) void
>
> Doing this means gcc can't actually eliminate the function.
>
> I think your only option, if we want to keep the code but still let
> gcc eliminate the function, is to #if 0 it/comment it out.

I don't think that's right, __attribute__((unused)) doesn't prevent gcc
From eliminating a function, maybe you're confusing it with
__attribute__((used))?

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150307/7af66fd3/attachment.sig>